Skip to content

fix(dashboard): honor fixed-offset event timezones - #8649

Open
pi0n00r wants to merge 3 commits into
nextcloud:mainfrom
pi0n00r:fix/dashboard-fixed-offset-tz
Open

fix(dashboard): honor fixed-offset event timezones#8649
pi0n00r wants to merge 3 commits into
nextcloud:mainfrom
pi0n00r:fix/dashboard-fixed-offset-tz

Conversation

@pi0n00r

@pi0n00r pi0n00r commented Jul 28, 2026

Copy link
Copy Markdown

Summary

  • normalize valid UTC+/-HH:MM and UTC+/-HHMM TZID values before the dashboard widget compares or formats event start times
  • preserve the event wall clock while attaching its explicit fixed offset
  • leave UTC, IANA TZIDs, floating values, all-day values, and source event data unchanged

Problem

Sabre VObject falls back to PHP's default timezone when a non-IANA fixed-offset TZID such as UTC-04:00 cannot be resolved. The Calendar view can still render the wall time correctly, but CalendarWidget receives a DateTimeImmutable carrying the fallback timezone and emits the wrong sinceId and relative subtitle.

For example, DTSTART;TZID="UTC-04:00":20260728T111500 can be emitted by the dashboard as 11:15 UTC instead of 11:15 at -04:00.

Validation

  • added a full widget regression covering fixed-offset normalization
  • asserted the original search result and TZID remain unchanged
  • PHP 8.4 syntax checks pass for the implementation and test

The change is display-only and performs no calendar write.

pi0n00r added 2 commits July 28, 2026 01:46
@pi0n00r
fix(dashboard): honor fixed-offset event timezones
5a83eff 
Signed-off-by: pi0n00r <131018595+pi0n00r@users.noreply.github.com>
@pi0n00r
test(dashboard): assert source event remains unchanged
4b3751b 
Signed-off-by: pi0n00r <131018595+pi0n00r@users.noreply.github.com>
@pi0n00r
pi0n00r force-pushed the fix/dashboard-fixed-offset-tz branch from 4ac7d19 to 4b3751b Compare July 28, 2026 05:46
@pi0n00r
fix(dashboard): leave all-day values unchanged
2ce1d3f 
Signed-off-by: pi0n00r <131018595+pi0n00r@users.noreply.github.com>
@pi0n00r pi0n00r closed this Jul 28, 2026
@pi0n00r
pi0n00r deleted the fix/dashboard-fixed-offset-tz branch July 28, 2026 05:55
@pi0n00r
pi0n00r restored the fix/dashboard-fixed-offset-tz branch July 28, 2026 06:04
@pi0n00r pi0n00r reopened this Jul 28, 2026
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner
@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner
@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pi0n00r